oops, forgot to check out the student view. looks good. with the exception
of the first item which is a question for JP, the below comments are all
minor copy changes. lakshmi, feel free to change them or I can do it later.

- I think adding collapsed-by-default multiple-choice answers and
free-response answers are useful to students  -- @jpslav you were worried
the page too long with these additions -- see screenshot.

- when students are looking at the combined exercise and feedback page --
we can remove the "show exercise" link in the nav menu. This is no longer
necessary since we are now showing the exercise on that page (yay!)

- I would change "Your free responses" to "Your Free Responses" to match
the other header styles

- also, there is a typo in the case where there are no available solutions
-- I think it says" no availble solutions" (this is not a new typo ha)

but otherwise the students are now sorted in alphabetical order and by
cohort, and the researchers now have permission to view the new page.


On Wed, May 21, 2014 at 6:47 PM, Kim Davenport <kjd@kindlinglabs.com> wrote:

> Sorry if any of my comments were addressed above.
>
> - the prev/next navigation isn't quite right. in the db I'm testing,
> clicking Next and Previous Exercise take me to a different class. (If I'm
> signed in as the instructor, it does properly return a security exception.)
>
> for example, in my DB if I'm looking at AE 17354, the next button takes me
> to AE 2191.It seems like the links on the assignment view page are correct,
> just not on the problem view. Can you reproduce this?
>
> - the formatting for non-registered students looks a tad funky -- see
> screenshot.
>
> - minor, but to be consistent can you make the nav menu copy read ...
>
> Class
> Assignment
> Previous Exercise
> Next Exercise
>
> ... instead of Go to Assignment and Go to Class? Also, I feel like UX wise
> it makes more sense to put those nav links in the body (at the top and
> bottom), but maybe it's fine to wait to do this since I'm not sure about
> the best way to do this. Probably top and bottom nav tabs that span the
> body.
>
>
> On Wed, May 21, 2014 at 5:06 PM, Dantemss <notifications@github.com>wrote:
>
>> In app/models/student_exercise.rb:
>>
>> > @@ -38,7 +40,14 @@ class StudentExercise < ActiveRecord::Base
>> >
>> >    validate :changes_match_state, :on => :update
>> >    validate :has_at_least_one_free_response, :on => :update
>> > -
>> > +
>> > +  scope :by_student, lambda { |present_user|
>>
>> Oh another thing, maybe change the present_user argument name to just
>> user. Present_user has some other meaning for controllers. Just to make it
>> clear.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/lml/ost/pull/348/files#r12922816>
>> .
>>
>
>