Updated pull request.

Thanks,

Shaoshan

From: Sharad Gandhi <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, March 3, 2014 11:10 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Subject: Re: [naarad] add CDF support to Naarad: generate CDF graphs for important metrics in the summary page (#142)


In src/naarad/metrics/metric.py:

> @@ -309,20 +308,42 @@ def calc(self):
>              NEW_FH.write('\n')
>
>    def graph(self, graphing_library = 'matplotlib'):


JMETER Metric currently overrides this method. We may want to add cdf plotting in there as well. If we make a separate plot_cdf in metric.py, then jmeter metric can just use that.

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/142/files#r10223593>.