! Sceditor js update fixes #2311

Signed-off-by: Antes <antes@simplemachines.org>
issue with $smcFunc['ucwords'] not being loaded

- addresses an issue with the upgrade script where $smcFunc['ucwords'] was not defined for that process
- tested using the SMF 2.1 upgrade an a local installation of SMF 2.0.9
- also edited some grammar within comments in that area of code (let's = let us)

Signed-off-by: -Underdog- github.underdog@gmail.com
- removed line break at end of file

Signed-off-by: -Underdog- github.underdog@gmail.com
possible undefined variables in upgrade.php

- where name and/or password fields from the submitted form were left empty, undefined errors occurred

Signed-off-by: -Underdog- github.underdog@gmail.com
- removed line break at end of file

Signed-off-by: -Underdog- github.underdog@gmail.com
allow mod authors to add their own icon

- allow mod authors to dynamically add elements to the menu
- this can include background image, DOM events, etc.

Signed-off-by: -Underdog- github.underdog@gmail.com
- remove line break at end of file

Signed-off-by: -Underdog- github.underdog@gmail.com
missing second parameter for closure 

- second parameter needed for closure else result is syntax error

Signed-off-by: -Underdog- github.underdog@gmail.com
- removed line break at end of file

Signed-off-by: -Underdog- github.underdog@gmail.com
improper use of closure

- variables passed into the anonymous function from the parent scope has
to be via the use language construct

Signed-off-by: -Underdog- github.underdog@gmail.com
! go up/down

Signed-off-by: Antes <antes@simplemachines.org>
Signed-off-by: Antes <antes@simplemachines.org>
! slipped little code :/

Signed-off-by: Antes <antes@simplemachines.org>
Oh and that by @Oldiesmann

Signed-off-by: Antes <antes@simplemachines.org>
! my bad :/ I still blame Oldiesmann

Signed-off-by: Antes <antes@simplemachines.org>
! I need to check my Git stuff... some changes are not going to repo

Signed-off-by: Antes <antes@simplemachines.org>
Merge pull request #2410 from Antes/theme_fix

Template fixes
Merge pull request #2406 from Underdog-01/patch-10

undefined variables in upgrade.php
Merge pull request #2405 from Underdog-01/patch-9

fixed improper use of closure
Merge pull request #2407 from Underdog-01/patch-11

allow mod authors to add their own menu icon