Ianoc/scalding 210

Brings @jcoveney and my old stuff up to date
Not opposed. Follow up if this passes as an issue / pr though ?

On Friday, December 5, 2014, Alex Levenson <notifications@github.com> wrote:

> In scalding-core/src/test/scala/com/twitter/scalding/CoreTest.scala:
>
> >      val input = (1 to 1000).flatMap { i => List((-1, i), (1, i)) }.toList
> >      JobTest(new ForceToDiskJob(_))
> >        .source(Tsv("in", ('x, 'y)), input)
> >        .sink[(Int, Int, Int)](Tsv("out")) { outBuf =>
> > -        "run correctly when combined with joinWithTiny" in {
> > -          outBuf.size must_== 2000
> > +        (idx + ": run correctly when combined with joinWithTiny") in {
> > +          outBuf should have size 2000
>
> just saw that you were using === in some of the tests at the top of the
> diff then switched to the "should be" / "should haves" later (or maybe it's
> your vs. jco's branch), so ideally we'd just stick with one but not a huge
> deal.
>
> I don't particularly like the english sentence style assertions, === is
> short and is pretty clear IMO.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/twitter/scalding/pull/1116/files#r21410888>.
>