Both fixed, although I thought that warning is maybe too much as you
will see this on each request. But nevermind, this is not meant for
production use at all.

LZ

On Fri, Jan 03, 2014 at 06:09:53AM -0800, Dominic Cleal wrote:
> > +    # we support only one subnet
> > +    def loadSubnets
> > +      super
> > +      begin
> > +        doc = REXML::Document.new xml = dump_xml
> > +        doc.elements.each("network/ip") do |e|
> > +          next if e.attributes["family"] == "ipv6"
> > +          netmask = e.attributes["netmask"]
> > +          gateway = e.attributes["address"]
> > +          network = IPAddr.new(gateway).mask(netmask).to_s
> > +          subnet = Proxy::DHCP::Subnet.new(self, network, netmask)
> > +        end
> > +      rescue Exception => e
> > +        msg = "DHCP virsh provider error: unable to retrive virsh info: #{e}"
> > +        logger.error msg
> > +        logger.debug xml unless xml.nil?
> 
> xml isn't defined at all, you'd need to initialise it to nil or use `defined?`
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/smart-proxy/pull/116/files#r8634474

-- 
Later,

 Lukas "lzap" Zapletal
 irc: lzap #theforeman