I guess it's ok either way. Studio should have ensured the course id is
acceptable.


On Mon, May 12, 2014 at 11:11 AM, Adam <notifications@github.com> wrote:

> In common/lib/xmodule/xmodule/modulestore/xml_importer.py:
>
> > -                            # Importing over existing course, check
> > -                            # that runs match or fail
> > -                            if course.location.name != module.location.name:
> > -                                log.error(
> > -                                    'A course with ID %s exists, and this '
> > -                                    'course has the same organization and '
> > -                                    'course number, but a different term that '
> > -                                    'is fully identified as %s.',
> > -                                    course.location.course_id,
> > -                                    module.location.course_id
> > -                                )
> > -                                bad_run = True
> > -                                break
> > +                    if target_location_namespace is None:
> > +                        for course in courses:
> > +                            if course.location.course_id.startswith(course_prefix):
>
> @dmitchell <https://github.com/dmitchell> , I we added the check on target_location_namespace
> is None to distinguish between courses being imported via studio and
> courses imported via management command. The original PR that added this
> functionality was only supposed to apply to the management command: #3145<https://github.com/edx/edx-platform/pull/3145>.
> Should I still delete condition?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/edx/edx-platform/pull/3626/files#r12534157>
> .
>