On Sun, Jun 01, 2014 at 11:53:05AM -0700, Hannu Valtonen wrote:
> > @@ -329,7 +329,7 @@ def pack_loose_objects(self):
> >          for sha in self._iter_loose_objects():
> >              objects.add((self._get_loose_object(sha), None))
> >          self.add_objects(list(objects))
> > -        for obj, path in objects:
> > +        for obj, path in objects: # pylint: disable=W0612
> 
> The W0612 in general does detect a useful class of errors (unused variables) 
> 
> If we start wholesale ignoring these and the C0330 there's really not much point in the whole PR (the indent commit is basically pretty much solely C0330) 
I think most of these are useful changes, regardless of whether or not
they are reported by pylint.

pylint is useful for finding problems, but its output is always
very noisy. I value code readability much more than pylint
cleanness. Sprinkling # pylint: disable='s everywhere is indeed not
a good solution either.

Several other tools (pep8, pyflakes) are less problematic in that
regard.

Cheers,

Jelmer