My comment was not about the intended design, only about the implementation
relative to best practices.


On Wed, Mar 12, 2014 at 9:55 AM, Anthony Scopatz
<notifications@github.com>wrote:

> In src/csv_back.cc:
>
> > @@ -25,6 +25,10 @@
> >    fs::create_directory(path);
> >  }
> >
> > +CsvBack::~CsvBack() {
> > +  Flush();
>
>  So I should be more precise. If there is throwable code in a destructor,
> it needs to be handled in the destructor.
>
> That is fine. But there is really no other place to call the
> last-opportunity flush. The destructor is the last opportunity.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/767/files#r10520715>
> .
>



-- 
Matthew Gidden
Ph.D. Candidate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192