Add request state updating functionality to API

WIP

Adds a new `update_state` method to the API that uses the existing API key mechanism to send a status update to a request created via an external API request. Intended usage - foi-register end-users confirming whether the information they requested has been disclosed ([the parallel work on foi-register can be found here](https://github.com/mysociety/foi-register/tree/issues/169-ask-user-to-confirm-request-state)). Status description mismatches should be handled on the foi-register side but unexpected status values are rejected with a 500 error by the API.

Adds an optional parameter to the pre-existing `add_correspondence` API method to allow it to update status (intended use - updates from a public body) if a `state` value is supplied. Again, the foi-register code is responsible for handling state description mismatches but in this case the API deals with erroneous data by ignoring that part of the request.

Apologies for having restructured `api_controller_spec` but I kept losing track of which API methods the various tests were targeting. I will be happy to change it back before finalising the Pull Request if I've caused trouble.
This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

  skenaja@gmail.com
    Domain alexskene.com has exceeded the max emails per hour (440/400 (110%)) allowed.  Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from o5.sgmail.github.com ([192.254.113.10]:28806)
	by zurich.footholds.net with smtps (UNKNOWN:DHE-RSA-AES128-GCM-SHA256:128)
	(Exim 4.82)
	(envelope-from <bounces+848413-9a96-alex=alexskene.com@sgmail.github.com>)
	id 1WzpXu-0008V3-WE
	for alex@alexskene.com; Wed, 25 Jun 2014 16:55:39 +0100
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sgmail.github.com; 
	h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; 
	s=smtpapi; bh=1VkhsfYsyXClu40vx2KDh0AG+JM=; b=hYSA5+4WI2ZkiLXk8S
	YKvMWKnBePPzRpt6fCPG4VoyHGzKqtfCnYXqIXeZHFpJwxY9Q6TcllAhp8hSHTVV
	SRwEtYHLu0uRTxLRkaaaSGWVPZ7GgpUiUg1tj7BnciNJZwpeYPGGoaeH8kDaXUAO
	GpCsJWqEhQMEd6Geu5KcEimRY=
Received: by mf198.sendgrid.net with SMTP id mf198.7817.53AAF0F211
        Wed, 25 Jun 2014 15:55:30 +0000 (UTC)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17])
	by ismtpd-024.iad1.sendgrid.net (SG) with ESMTP id 146d3bd32ca.91e.35ce79
	for <alex@alexskene.com>; Wed, 25 Jun 2014 15:55:30 +0000 (GMT)
Date: Wed, 25 Jun 2014 08:55:29 -0700
From: Hound <notifications@github.com>
Reply-To: mysociety/alaveteli <reply@reply.github.com>
To: mysociety/alaveteli <alaveteli@noreply.github.com>
Message-ID: <mysociety/alaveteli/pull/1631/r14195070@github.com>
In-Reply-To: <mysociety/alaveteli/pull/1631@github.com>
References: <mysociety/alaveteli/pull/1631@github.com>
Subject: Re: [alaveteli] Add request state updating functionality to API
 (#1631)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_53aaf0f1b7ea2_6383fb6867ed2a0324844";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Recipient: skenaja
List-ID: mysociety/alaveteli <alaveteli.mysociety.github.com>
List-Archive: https://github.com/mysociety/alaveteli
List-Post: <mailto:reply@reply.github.com>
List-Unsubscribe: <mailto:unsub+p-14195070-1fdae892e88fc6f003bb17494a590533f95bf753-510285@reply.github.com>,
 <https://github.com/notifications/unsubscribe/510285__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MTkzMzA5MjksImRhdGEiOnsiaWQiOjM1MzExOTc0fX0=--4ec08bc6ad4ba2c59d2fdc95fd36c8559afc6326>
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: alex@alexskene.com
X-SG-EID: hQ+xzKT9K37JzZfKEXr3QNageyq61ruQMWnl5rBwpIKwhSyD16ReWJBQEHjedT2GbXOLS3XByQHgeR+Giu3Ojv8cKLZuOSWodVYp9YkI9nXpBrf+DwCjpl/nTxGDVFh3UI/Uu2A/v0qy7prJw37FI+KpvX1mxv3Jwxdsy5jyJBY=

----==_mimepart_53aaf0f1b7ea2_6383fb6867ed2a0324844
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

> +            request_data = {
> +                "title" => "Tell me about your chickens",
> +                "body" => "Dear Sir,\n\nI should like to know about your chickens.\n\nYours in faith,\nBob\n",
> +                "external_url" => "http://www.example.gov.uk/foi/chickens_23",
> +                "external_user_name" => "Bob Smith",
> +            }
> +
> +            post :create_request,
> +                 :k => public_bodies(:geraldine_public_body).api_key,
> +                 :request_json => request_data.to_json
> +            response.should be_success
> +
> +            response.content_type.should == "application/json"
> +            response_body = ActiveSupport::JSON.decode(response.body)
> +            response_body["errors"].should be_nil
> +            response_body["url"].should =~ /^http/

Prefer single-quoted strings when you don't need string interpolation or special symbols.

---
Reply to this email directly or view it on GitHub:
https://github.com/mysociety/alaveteli/pull/1631/files#r14195070
----==_mimepart_53aaf0f1b7ea2_6383fb6867ed2a0324844
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p>In spec/controllers/api_controller_spec.rb:</p>
<pre style='color:#555'>&gt; +            request_data = {
&gt; +                &quot;title&quot; =&gt; &quot;Tell me about your chickens&quot;,
&gt; +                &quot;body&quot; =&gt; &quot;Dear Sir,\n\nI should like to know about your chickens.\n\nYours in faith,\nBob\n&quot;,
&gt; +                &quot;external_url&quot; =&gt; &quot;http://www.example.gov.uk/foi/chickens_23&quot;,
&gt; +                &quot;external_user_name&quot; =&gt; &quot;Bob Smith&quot;,
&gt; +            }
&gt; +
&gt; +            post :create_request,
&gt; +                 :k =&gt; public_bodies(:geraldine_public_body).api_key,
&gt; +                 :request_json =&gt; request_data.to_json
&gt; +            response.should be_success
&gt; +
&gt; +            response.content_type.should == &quot;application/json&quot;
&gt; +            response_body = ActiveSupport::JSON.decode(response.body)
&gt; +            response_body[&quot;errors&quot;].should be_nil
&gt; +            response_body[&quot;url&quot;].should =~ /^http/
</pre>
<p>Prefer single-quoted strings when you don't need string interpolation or special symbols.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br>Reply to this email directly or <a href="https://github.com/mysociety/alaveteli/pull/1631/files#r14195070">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/510285__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTMzMDkyOSwiZGF0YSI6eyJpZCI6MzUzMTE5NzR9fQ==--11c9b2e30b116abde617c9883c2dde5d2914d0f1.gif" width="1" /></p>
----==_mimepart_53aaf0f1b7ea2_6383fb6867ed2a0324844--