Ah damn, you're right. Doesn't the same go for "Enqueued ..." also?

—Douwe

> On 21 mei 2014, at 15:32, Cristian Bica <notifications@github.com> wrote:
> 
> In lib/active_job/performing.rb:
> 
> > @@ -0,0 +1,14 @@
> > +require 'active_job/parameters'
> > +
> > +module ActiveJob
> > +  module Performing
> > +    def perform_with_deserialization(*serialized_args)
> > +      ActiveSupport::Notifications.instrument "perform.active_job", adapter: self.class.queue_adapter, job: self.class, args: serialized_args
> As the logging says "Performed..." we should mode the instrumenting after performing the job or change the log message to "Performing...". Otherwise developers will see in logs "Performed..." and will get a crash report if the job fails.
> 
> —
> Reply to this email directly or view it on GitHub.