Hello,
    Sorry to be pedantic, but you mean to add the override as seen below?

>  virtual void analyze(const edm::Event&, const edm::EventSetup&) override;

Should this be added to every class that has been modified? Thank you 
and best regards,
Ian

On 1/29/2014 6:06 PM, Chris Jones wrote:
>
> In Validation/EventGenerator/interface/BasicGenParticleValidation.h:
>
> >      public:
> >  	explicit BasicGenParticleValidation(const edm::ParameterSet&);
> >  	virtual ~BasicGenParticleValidation();
> > -	virtual void beginJob();
> > -	irtual void endJob();
> > +
> >  	virtual void analyze(const edm::Event&, const edm::EventSetup&);
>
> Would be good to put an |override| here as well.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/cms-sw/cmssw/pull/2229/files#r9274449>.
>


-- 
Dr. Ian M. Nugent
III. Physikalisches Institut B
RWTH Aachen, D-52056 Aachen
Tel: +49 241 80-27295
Email: nugent@physik.rwth-aachen.de