Fixed and updated the push request

From: Sharad Gandhi <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, March 24, 2014 9:26 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Subject: Re: [naarad] add diff % SLA support to Naarad (#169)


In src/naarad/sla.py:

>      self.sla_type = sla_type
>      self.is_processed = False
> +    self.threshold = None
> +    self.percent_threshold = None


Use threshold and stat_value, so you can reuse existing methods. Absolute or Diff sla can be indicated by a different field in sla?

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/169/files#r10895250>.