Cc pdlogs 61

Updated after review comments fro the ENT feature..  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against chronos_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
So,
What is the user supposed to do?  If it restarts ok then that’s fine.  What happens if the error is persistent? Abandon this version of the software?

Thanks,
David

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Thursday, December 18, 2014 10:58 AM
To: Metaswitch/chronos
Cc: David Collins
Subject: Re: [chronos] Cc pdlogs 61 (#92)


In src/include/chronos_ent_definitions.h<https://github.com/Metaswitch/chronos/pull/92#discussion-diff-22054592>:

> +

> +static const PDLog CL_CHRONOS_STARTED

> +(

> +  PDLogBase::CL_CHRONOS_ID + 2,

> +  PDLOG_NOTICE,

> +  "Chronos started.",

> +  "The Chronos application has started.",

> +  "Normal.",

> +  "None."

> +);

> +

> +static const PDLog CL_CHRONOS_REACTOR_FAIL

> +(

> +  PDLogBase::CL_CHRONOS_ID + 3,

> +  PDLOG_ERR,

> +  "Fatal - Couldn't create the event reactor service.",

The reactor service is the IO loop Chronos uses (it's part of libevent)
I would just say that Chronos hit a fatal error on startup and has terminated.

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/chronos/pull/92/files#r22054592>.