If there are catches inside of each "action" that should be good enough.


On Fri, Apr 25, 2014 at 1:48 PM, simon.jiang <notifications@github.com>wrote:

> In
> tools/plugins/com.liferay.ide.project.core/src/com/liferay/ide/project/core/model/ProjectUpgradeOpMethods.java:
>
> > +        int totalWork = 100;
> > +        int perUnit = totalWork / ( workUnit * actionUnit );
> > +        monitor.beginTask( "Upgrading Project ", totalWork );
> > +
> > +        for( String projectItem : projectItems )
> > +        {
> > +            if( projectItem != null )
> > +            {
> > +                IProject project = ProjectUtil.getProject( projectItem );
> > +                monitor.setTaskName( "Upgrading Project " + project.getName() );
> > +
> > +                for( String action : projectActions )
> > +                {
> > +                    if( action.equals( "RuntimeUpgrade" ) )
> > +                    {
> > +                        upgradeRuntime( project, runtimeName, monitor, perUnit );
>
> I added try catch in
> rebuildService,runLaut,upgradeDTDHeader,upgradeRuntime. Do I need to add
> try catch in top level or remove them and only add try catch in top level?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gamerson/liferay-ide/pull/544/files#r11983910>
> .
>



-- 
Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com