Okay - it doesn't seem too technical to me. What do you suggest the message
should be? Should I NSLog this message?




From:	Mike Rhodes <notifications@github.com>
To:	cloudant/CDTDatastore <CDTDatastore@noreply.github.com>
Cc:	Adam Cox <gadamc@cloudant.com>
Date:	05/29/2014 03:19
Subject:	Re: [CDTDatastore] Adds support for filtered pull replication.
            (#23)



In Classes/common/CDTReplicator/CDTPullReplication.m:


> +        if (error) {
> +            *error = localError;
> +            return nil;
> +        }
> +    }
> +
> +    NSMutableDictionary *doc = [[NSMutableDictionary alloc] init];
> +
> +    [doc setObject:self.source.absoluteString forKey:@"source"];
> +
> +    if (self.target) {
> +        [doc setObject:self.target.name forKey:@"target"];
> +    }
> +    else {
> +        if (error) {
> +            NSString *msg = @"CDTPullReplication
-dictionaryForReplicatorDocument Error. Target undefined";



Over-technical. This sort of stuff should be logged rather than returned in
the NSError instance.


—
Reply to this email directly or view it on GitHub.