Exclude sprites and any GIFs from processing, Firefox plugin: handle dynamic content, fixed #5

Good point!

On 2014-09-24 12:32, Dmitry Berezovsky wrote:
>
> In elogio-firefox/lib/main.js:
>
> >                      bridge.emit(bridge.events.newImageFound, imageObject);
> >                  }
> >              });
> >              // When user click on the elogio icon near the image
> >              contentWorker.port.on(bridge.events.onImageAction, function (imageObject) {
> >                  if (currentTab === tabs.activeTab) {
> > -                    bridge.emit(bridge.events.onImageAction, imageObject);
> > +                    if(sidebarIsHidden){
> > +                        elogioSidebar.show();
> > +                    }else{
> > +                        bridge.emit(bridge.events.onImageAction, imageObject);
>
> No, that will not work since |elogioSidebar.show()| causes loading 
> document into side bar which is async process. Emitting event 
> immediately after .show() will not be handled since panel is not 
> initialized yet. This is a part of #6 
> <https://github.com/commonsmachinery/elogio.firefox/issues/6> which is 
> under development right now.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/commonsmachinery/elogio.firefox/pull/9/files#r17964157>.
>