Reuse NeutronObject comparator

This is a static object, which is thread-safe and can therefore be
reused betwen instances and requests.

Change-Id: Ib920ff6736ab451b402e4691717eb2f4eee59a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix neutron pagination

This patch fixes a logic mistake which results in dead code being
reported. startPos is guaranteed to be non-null by virtue of being
always assigned.

The problem is that the detection that the marker is not found is not
correct, as binarySearch() will report the negated insertion point.

Also improves performance by using a primitive type instead of an
encapsulated object.

Change-Id: I525c2070d2794b1e001465ea925d95d432feca29
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix non-generic references to ArrayList

This patch adds the proper type specification.

Change-Id: I2482a37cc7517e2a08846f8401a9d0104bebea3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix a non-generic reference to Comparable

Fixes a warning stemming from not specifying the object type.

Change-Id: Ic7e833223246d56a95034ef84a1e012fa544a396
Signed-off-by: Robert Varga <rovarga@cisco.com>
Add serialVersionUID to Serializable classes

Each serializable class withouth serialVersionUID produces an eclipse
warning. It also means that the class has undefined versioning and
cannot be be upgraded -- this patch fixes all such classes.

Change-Id: I57696f47b312517acd44799e10850f4887dab2e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix raw use of Gauge

It is a generic type, so add type declarations to fix warnings.

Change-Id: I228629392261c22ec6a9037795aeb5bdbccc2dfe
Signed-off-by: Robert Varga <rovarga@cisco.com>
Use generic-aware empty collections

Rather than referring to the instances directly, use the generic-aware
factory methods.

Change-Id: Ie0cdd4b3fdc03da1cf723907d03420bd10c57e45
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix raw reference to SessionNegotiatior

Add a wildcard and be done with it.

Change-Id: Ifc72e1fe88e9d5ee9047c55ed93fc0fae7db331a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Fix raw references to SimpleNode

Just adds a wildcard.

Change-Id: I62114265db13ee1945c91282b7c572c3c91458ec
Signed-off-by: Robert Varga <rovarga@cisco.com>
Merge "Use generic-aware empty collections"
Merge changes I525c2070,Ib920ff67

* changes:
  Fix neutron pagination
  Reuse NeutronObject comparator
Merge changes Ic7e83322,I2482a37c

* changes:
  Fix a non-generic reference to Comparable
  Fix non-generic references to ArrayList
Merge "Add serialVersionUID to Serializable classes"
Merge "Fix raw use of Gauge"
Merge "Fix raw reference to SessionNegotiatior"
Merge "Fix raw references to SimpleNode"