Update directory to find performance graphs in for syncing to SF in nightly

I thought cronlogdir would be NightlyPerformance for performance and compiler
performance testing, but that's only true for performance testing. This
switches to use CHPL_TEST_PERF_DIR and CHPL_TEST_COMP_PERF_DIR which are
directly responsible for telling start_test where to put the graphs and html
directory.
Merge pull request #870 from ronawho/fix-perf-graph-sync

Update directory to find perf graphs in for syncing to SF in nightly

[reviewed by @thomasvandoren]

I thought cronlogdir would be NightlyPerformance for performance and compiler
performance testing, but that's only true for performance testing. This
switches to use CHPL_TEST_PERF_DIR and CHPL_TEST_COMP_PERF_DIR which are
directly responsible for telling start_test where to put the graphs and html
directory.
Fix par_iter_recursive .bad mismatch

The error this test reports moved from ChapelArray to ChapelIteratorSupport.
Updated the .bad to point at the new module.  Also removed the line number from
the .bad and added a .prediff to remove it from the test output.
Merge pull request #871 from daviditen/fix_par_iter_recursive

Fix par_iter_recursive .bad mismatch

The error this test reports moved from ChapelArray to ChapelIteratorSupport.
Updated the .bad to point at the new module. Also removed the line number from
the .bad and added a .prediff to remove it from the test output.
Fix coverity 1212409 by using std::vector.

Update int array that was not initialized in reachingDefinitionsAnalysis.cpp to
simply be a std::vector<int>. std::vector will take care of the initialization,
and coverity should be happy.
Merge branch 'master' of https://github.com/chapel-lang/chapel into coverity-1212409
Added a missing 'ref' clause in a forall.

While there, brought crash1callDestructorsAddon.chpl
in sync with crash1callDestructorsMain.chpl.
The former started out as a partial copy of the latter.
While it is not important that the two be identical,
keeping them that way will avoid the question
"why are they different".

Also updated the corresponding .future.
Adjusted .bad for autoCopyWithBegin.chpl.

Probably because of the forall intent commit #614,
this test is now failing earlier.
I updated .bad, and correspondingly the .prediff.
I also have the .prediff remove the chpl version, to avoid noise.

I verified that the "before" and the "after" failures are due to
the same "number of actuals does not match number of formals"
internal error for a call to the same function with the same argument,
at the same location: autoCopyWithBegin.chpl:15.
So it is sufficient to just adjusting .bad.

Recording this just in case - before today the failure was here:

#3  0x00000000004b69f0 in checkFormalActualTypesMatch () at checks.cpp:662
#4  0x00000000004b5d50 in check_afterCallDestructors () at checks.cpp:450
#5  0x00000000004b5aab in check_parallel () at checks.cpp:204
#6  0x00000000004bba4d in runPass (tracker=..., passIndex=20) at runpasses.cpp:2

and since today it changed to:

#3  0x000000000055afcc in insertReferenceTemps (call=0xfe4be0) at callDestructors.cpp:881
#4  0x000000000053c78a in insertAutoCopyDestroyForTaskArg (arg=0x2703350, fcall=0xf16010, fn=0x396c0c0, firstCall=true) at parallel.cpp:264
#5  0x000000000053cad0 in bundleArgs (fcall=0xf16010, baData=...) at parallel.cpp:305
#6  0x00000000005424d6 in passArgsToNestedFns (nestedFunctions=...) at parallel.cpp:1169
#7  0x0000000000541ed9 in parallel () at parallel.cpp:1116
#8  0x00000000004bdd3b in runPass (tracker=..., passIndex=20) at runpasses.cpp:2
Remove localDefs init loop. std::vector does this already.
Merge pull request #874 from vasslitvinov/fix-.bad-mismatches-from-forall-intents

Fixed .bad mismatches from forall intents merge.

See individual commits for details.
Fixed Coverity defect 1231860.

*** CID 1231860:  Uninitialized pointer read  (UNINIT)
/compiler/resolution/wrappers.cpp: 416
in reorderActuals(FnSymbol *, Vec<ArgSymbol *, (int)4> *, CallInfo *)()

410               need_to_reorder = true;
411             formals_to_formals[i-1] = j-1;
412           }
413         }
414       }
415       if (need_to_reorder) {
>>>     CID 1231860:  Uninitialized pointer read  (UNINIT)
>>>     Declaring variable "savedActuals" without initializer.
416         Expr* savedActuals[numArgs];
417         int i = 0;
418         // remove all actuals in an order
419         for_actuals(actual, info->call)
420           savedActuals[i++] = actual->remove();
421         // reinsert them in the desired order

The group consensus is that using std::vector is preferable over C arrays.
So I switched 'savedActuals' to be that.
Merge pull request #875 from vasslitvinov/fix-coverity-defect-1231860

Fixed Coverity defect 1231860.

*** CID 1231860:  Uninitialized pointer read  (UNINIT)
/compiler/resolution/wrappers.cpp: 416
in reorderActuals(FnSymbol *, Vec<ArgSymbol *, (int)4> *, CallInfo *)()

410               need_to_reorder = true;
411             formals_to_formals[i-1] = j-1;
412           }
413         }
414       }
415       if (need_to_reorder) {
>>>     CID 1231860:  Uninitialized pointer read  (UNINIT)
>>>     Declaring variable "savedActuals" without initializer.
416         Expr* savedActuals[numArgs];
417         int i = 0;
418         // remove all actuals in an order
419         for_actuals(actual, info->call)
420           savedActuals[i++] = actual->remove();
421         // reinsert them in the desired order

The group consensus is that using std::vector is preferable over C arrays.
So I switched 'savedActuals' to be that.

Suggested by Elliot, reviewed by Tom.
Converted a couple more C arrays to std::vector in wrappers.cpp.
Merge pull request #876 from vasslitvinov/C-array--to--std-vector

Converted a couple more C arrays to std::vector in wrappers.cpp.

Elliot suggested this - as we discussed for #875, std::vector is preferable to C arrays.
Merge pull request #872 from thomasvandoren/coverity-1212409

Fix coverity 1212409 by using std::vector.

Update int array that was not initialized in reachingDefinitionsAnalysis.cpp to
simply be a std::vector<int>. std::vector will take care of the initialization,
and coverity should be happy.

r: @vasslitvinov
Merge branch 'master' of https://github.com/chapel-lang/chapel into triage