[Privacy Panel] merge request to apps

Thx, done☺

Regards, Wojtek Łakomy

From: Zibi Braniecki [mailto:notifications@github.com]
Sent: Wednesday, October 29, 2014 6:04 PM
To: mozilla-b2g/gaia
Cc: Lakomy, Wojciech (REC)
Subject: Re: [gaia] [Privacy Panel] merge request to apps (#25368)


In apps/privacy-panel/js/sms/main.js:

> +        return;

> +      }

> +

> +      var locateReply = function(res, pos) {

> +        var lat, lon;

> +

> +        if ( ! res) {

> +          console.warn('Error while trying to locate a phone, ' + pos);

> +          return;

> +        }

> +

> +        lat = pos.coords.latitude;

> +        lon = pos.coords.longitude;

> +

> +        this._sendSMS(number, navigator.mozL10n.get('sms-locate-1') + ' ' +

> +          lat + ',' + lon + ' ' + navigator.mozL10n.get('sms-locate-2'));

This is not going to work for many languages. See: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Avoid_concatenations.2C_use_placeholders_instead

—
Reply to this email directly or view it on GitHub<https://github.com/mozilla-b2g/gaia/pull/25368/files#r19553672>.