WIP: Introduce a context object on RESTStorage to prepare for future changes

Per feedback on #1417, I have added a Context object to the major apiserver interfaces.

This is a prerequisite to staging in support for enabling the namespace of a request to get set on a context and passed down the call-stack.

Other future potential use cases:

1. request id (traceability)
2. oauth token for request (when user is calling an API that delegates to another call)
3. user unique identifier (per accts, so actions can get traced to a user)
4. etc.

If folks are ok with this general pattern, I will add the Godeps changes in an additional commit.

@lavalamp @smarterclayton 
I may be missing something reading this on the phone but I thought I was consistent in always naming the first argument to a function "ctx"


> On Sep 25, 2014, at 7:56 PM, Clayton Coleman <notifications@github.com> wrote:
> 
> In pkg/api/context.go:
> 
> > +Unless required by applicable law or agreed to in writing, software
> > +distributed under the License is distributed on an "AS IS" BASIS,
> > +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > +See the License for the specific language governing permissions and
> > +limitations under the License.
> > +*/
> > +
> > +package api
> > +
> > +import (
> > +	"code.google.com/p/go.net/context"
> > +)
> > +
> > +// NewContext instantiates a base context object for request flows
> > +func NewContext() context.Context {
> > +	return context.Background()
> On Sep 25, 2014, at 7:49 PM, Derek Carr <notifications@github.com> wrote: In pkg/api/context.go: > +Unless required by applicable law or agreed to in writing, software > +distributed under the License is distributed on an "AS IS" BASIS, > +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > +See the License for the specific language governing permissions and > +limitations under the License. > +*/  > + > +package api > + > +import ( > +	"code.google.com/p/go.net/context" > +) > + > +// NewContext instantiates a base context object for request flows > +func NewContext() context.Context { > +	return context.Background() Just re read the doc on TODO vs Background and see the difference for static analysis tools. Will update.  …
> Godoc also recommended naming the param "ctx"
> —
> Reply to this email directly or view it on GitHub.