the logic is ok,but not test