Swap the order of the checks since the filter can't be an the error state once the request has been read.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601329 13f79535-47bb-0310-9956-ffa450edef68
Remove unnecessary call since doRead() calls checkError()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601330 13f79535-47bb-0310-9956-ffa450edef68
Correct a location where an exception was still thrown directly rather than via the utility method where the error flag is also set.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601332 13f79535-47bb-0310-9956-ffa450edef68
Refactor to more closely align AsyncTimeout implementations

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601443 13f79535-47bb-0310-9956-ffa450edef68
Pull up waitingRequests.
NIO2 used a ConcurrentHashMap whereas BIO and APR/native used a Queue. Switch to ConcurrentHashMap for all since what we really want here is a Set (and there isn't a ConcurrentHashSet implementation).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601583 13f79535-47bb-0310-9956-ffa450edef68
Pull up AsyncTimeout
APR/native used a separate flag to stop the thread. This avoided issues where running was set true->false-true in quick succession. This fix is now available to NIO2 and BIO as well.
Note NIO does not (currently) use the AsyncTimeout

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601590 13f79535-47bb-0310-9956-ffa450edef68
Ensure that the new attribute name username is used in the tomcat-users.xml examples rather than the old name of user.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601597 13f79535-47bb-0310-9956-ffa450edef68
Fix failures to timeout async requests after refactoring. The removed condition was added to the APR connector (by me) some time ago but reviewing the current code I can see no reason for it to stay.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601761 13f79535-47bb-0310-9956-ffa450edef68
Correctly parse two consecutive escaped single quotes when used in UEL 
expression in a JSP.
Includes various unit tests that check the parsing of ${'\'\''}

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601785 13f79535-47bb-0310-9956-ffa450edef68
Provide a better error message when asynchronous operations are not supported by a filter or servlet. Patch provided by Romain Manni-Bucau. Issue was reported via users at tomcat.a.o.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601796 13f79535-47bb-0310-9956-ffa450edef68
Use StringManager for the async not supported message.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601850 13f79535-47bb-0310-9956-ffa450edef68
Remove obsolete documentation from realm package javadoc.
The text is something very old that talks about "debug" attribute and that there are two standard realms, JDBCRealm and MemoryRealm.
The up-to-date documentation is maintained in docs/config/realm.html

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601855 13f79535-47bb-0310-9956-ffa450edef68
Further fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56606
Update documentation for MemoryRealm.
Align MemoryUserRule class (in MemoryRuleSet.java) with MemoryUserCreationFactory class (in MemoryUserDatabase.java) so that "username" attribute is read first.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601886 13f79535-47bb-0310-9956-ffa450edef68
Move code that parses EL expressions within JSP template text from Parser to JspReader class.
This is done to get access to JspReader.nextChar(mark) to avoid calling reader.mark() in a loop, as that method allocates new Mark object on each call.

Also removed duplicate "start = reader.mark();" call, as parseELExpression() does update 'start'.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601924 13f79535-47bb-0310-9956-ffa450edef68
Fix comment typo and other clean-up

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1601977 13f79535-47bb-0310-9956-ffa450edef68
Correct typo in the name of a test class

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1602027 13f79535-47bb-0310-9956-ffa450edef68
https://issues.apache.org/bugzilla/show_bug.cgi?id=56581
Add test case for bug 56581.
It tests exception handling for committed responses.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1602046 13f79535-47bb-0310-9956-ffa450edef68
https://issues.apache.org/bugzilla/show_bug.cgi?id=56546 (very partial)
Reduce verbosity of clear references logging. Although it is a good tool for detecting leaks, the severity does not match the likely impact. Also avoid having more than one logging for one event even if filtering becomes less flexible.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1602159 13f79535-47bb-0310-9956-ffa450edef68
Partial revert to upgrade messages to warn.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1602188 13f79535-47bb-0310-9956-ffa450edef68
Pull up getLog() and add some supporting plumbing

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1602189 13f79535-47bb-0310-9956-ffa450edef68