more work on the products controller