! more proper type hinting

Signed-off-by: Spuds <spuds@spudsdesign.com>
! continuation of type hinting where required
! fix any dead assignments

Signed-off-by: Spuds <spuds@spudsdesign.com>
! next batch of type hinting etc

Signed-off-by: Spuds <spuds@spudsdesign.com>
! moar in this fun recursive game !

Signed-off-by: Spuds <spuds@spudsdesign.com>
! more of the same

Signed-off-by: Spuds <spuds@spudsdesign.com>
! Start of admin controllers

Signed-off-by: Spuds <spuds@spudsdesign.com>
! And so on :P

Signed-off-by: Spuds <spuds@spudsdesign.com>
! return doc fix

Signed-off-by: Spuds <spuds@spudsdesign.com>
Scrutinizer Auto-Fixes

This patch was automatically generated as part of the following inspection:
https://scrutinizer-ci.com/g/Spuds/Elkarte/inspections/13ef6cab-e47c-4061-b7d6-80a05ce4d5b3

Enabled analysis tools:
 - PHP Analyzer
 - JSHint
 - Security Advisory Checker
 - PHP Copy/Paste Detector
! fix some return statements

Signed-off-by: Spuds <spuds@spudsdesign.com>
! and onward !!!!

Signed-off-by: Spuds <spuds@spudsdesign.com>
! And some more in this cyclic game of hinting and fixing

Signed-off-by: Spuds <spuds@spudsdesign.com>
! and a few more hint / type fixes
! wrong method called in search controller plussearch1
! option should be options in VerificationControls.class.php

Signed-off-by: Spuds <spuds@spudsdesign.com>
! few more minor ones

Signed-off-by: Spuds <spuds@spudsdesign.com>
! add in private var declarations
! update the vars to _var

Signed-off-by: Spuds <spuds@spudsdesign.com>
! access the method of dir->path()
! remove odd assignment

Signed-off-by: Spuds <spuds@spudsdesign.com>
! add in missing var definitions for the class

Signed-off-by: Spuds <spuds@spudsdesign.com>
! add in missing var definitions for the class

Signed-off-by: Spuds <spuds@spudsdesign.com>
! add in missing var definitions for the class and rename to _
! change siseof to count

Signed-off-by: Spuds <spuds@spudsdesign.com>
! censor text passes by reference, so we should not use
pass in the functions like that

Signed-off-by: Spuds <spuds@spudsdesign.com>