I have made the required changes. Shall I push the commit?


On Sat, Mar 8, 2014 at 12:38 AM, Vinod Kumar <vinodkumarlogan@gmail.com>wrote:

> Ok..We need not have crossScalaVersions and util-logging's version is
> changed to 6.12.1
>
>
> On Sat, Mar 8, 2014 at 12:26 AM, Vinod Kumar <vinodkumarlogan@gmail.com>wrote:
>
>> We can remove 2.9.1.
>> I will make the "case x" change.
>> I tested it with both  2.9.3 and 2.10.3, and the compilation worked. Will
>> we use 2.9.2 version as well or is it for 2.9.3 only?
>>
>>
>> On Sat, Mar 8, 2014 at 12:20 AM, Pankaj Gupta <notifications@github.com>wrote:
>>
>>> In project/Build.scala:
>>>
>>> > -      "org.scala-tools.testing" % "specs_2.9.1" % "1.6.9" % "test"
>>> > +      "com.twitter" %% "ostrich" % "9.1.0" cross CrossVersion.binaryMapped {
>>> > +        case "2.9.1" => "2.9.2"
>>> > +        case "2.9.3" => "2.9.2"
>>> > +        case x => x
>>> > +      },
>>> > +      "com.twitter" %% "util-logging" % "6.6.0" cross CrossVersion.binaryMapped {
>>> > +        case "2.9.1" => "2.9.2"
>>> > +        case "2.9.3" => "2.9.2"
>>> > +        case x => x
>>> > +      },
>>> > +      "org.scala-tools.testing" %% "specs" % "1.6.9" % "test" cross CrossVersion.binaryMapped {
>>> > +        case "2.9.2" => "2.9.1"
>>> > +        case "2.9.3" => "2.9.1"
>>> > +        case x => x
>>> > +      }
>>> >      ),
>>> >      resolvers += "twitter repo" at "http://maven.twttr.com",
>>> >
>>>
>>> hope you have tried actually building the package and it does work okay
>>> for both scala versions ?
>>>
>>> --
>>> Reply to this email directly or view it on GitHub<https://github.com/twitter/cassovary/pull/50/files#r10394450>
>>> .
>>>
>>
>>
>