Merge 232929 "Fix a crash in URLFetcherCore by handling a case w..."

> Fix a crash in URLFetcherCore by handling a case where |request_| is NULL
>
> This is a speculative fix for the crash:
> https://crash-old.corp.google.com/reportdetail?reportid=4897b184b09b23c8#crashing_thread
>
> My hypothesis is that the request is released while there is a pending call to DidWriteBuffer().
> The request was maybe released because
> - the fetch was stopped or cancelled
> - or ReleaseRequest() was called in OnReadCompleted
>
>
> BUG=308626, 314241
>
> Review URL: https://codereview.chromium.org/46573008

TBR=droger@chromium.org

Review URL: https://codereview.chromium.org/69793005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234649 0039d316-1c4b-4281-b951-d872f2087c98
Merge 232898 "ChromeOS windows are transparent by default. This ..."

> ChromeOS windows are transparent by default. This allows the window header to be transparent when there is only one window on screen. This CL fixes a case where we were clobbering the window's default opacity.
> 
> BUG=312441
> TEST=See bug
> 
> Review URL: https://codereview.chromium.org/56623003

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/70233003

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234669 0039d316-1c4b-4281-b951-d872f2087c98
Merge 233471 "Suppress configure dialog when screen is locked"

> Suppress configure dialog when screen is locked
> 
> BUG=314263
> 
> Review URL: https://codereview.chromium.org/60553004

TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/70493005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234679 0039d316-1c4b-4281-b951-d872f2087c98
Incrementing VERSION to 32.0.1700.15

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234687 0039d316-1c4b-4281-b951-d872f2087c98
Fix the keyboard navigation issue for app_list.
BUG=318375
TBR=xiyuan

Review URL: https://codereview.chromium.org/62953018

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234856 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234738 "base: Disable the scoped handle verifier."

> base: Disable the scoped handle verifier.
> 
> Intended for M32 branch
> 
> BUG=318496
> TEST=none
> TBR=cpu@chromium.org
> 
> Review URL: https://codereview.chromium.org/68113012

TBR=rvargas@google.com

Review URL: https://codereview.chromium.org/68103015

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234899 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234615 "Make ColorChooserAura browser modal, not always-on..."

> Make ColorChooserAura browser modal, not always-on-top.
> 
> Parent the chooser widget to the content's browser window.
> (ColorChooserView already returns ui::MODAL_TYPE_WINDOW)
> Make it no longer always-on-top (has been since r144111).
> 
> BUG=295832,295832
> TEST=The Color chooser is browser modal, not always on top; see an example at <http://github.hubspot.com/pace/docs/welcome>.
> R=mukai@chromium.org,pkasting@chromium.org
> 
> Review URL: https://codereview.chromium.org/65733002

TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/59493010

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234914 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234650 "[sync] Fix behavior of "Use default settings" / "A..."

> [sync] Fix behavior of "Use default settings" / "Advanced" links
> 
> This CL fixes the behavior seen while switching between the "Use default
> settings" / "Advanced" modes of the sync setup dialog.
> 
> BUG=316547
> TEST=Switch between the "Use default settings" and "Advanced" modes. OK button must receive focus.
> R=rogerta@chromium.org
> 
> Review URL: https://codereview.chromium.org/69723002

TBR=rsimha@chromium.org

Review URL: https://codereview.chromium.org/68263017

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234942 0039d316-1c4b-4281-b951-d872f2087c98
Merge 233547 "cros: Use AlertDialog for remora device requisition."

> cros: Use AlertDialog for remora device requisition.
>
> BUG=313854
>
> Review URL: https://codereview.chromium.org/61523002

TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/59623014

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234943 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234425 "cros: Remora setup flow update"

> cros: Remora setup flow update
>
> - Use ConfirmDialog and update the messages;
> - Show remora confirm message on the network screen when it is enabled;
> - Restore general device requisition messaging;
>
> BUG=313854
>
> Review URL: https://codereview.chromium.org/68533008

TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/71483004

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234947 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234416 "Adds the concept of a 'safe mode' hotkey start"

> Adds the concept of a 'safe mode' hotkey start
> 
> The issue is that with Aura if something goes horribly wrong with the
> GPU, the user can get a 'black window' with no UI.
> 
> So for ConOps it is nice to have a way to start chrome with a set of
> flags that we know should get you a working chrome that they
> can troubleshoot.
> 
> To do this we require the user to hold ctrl + alt while starting
> chrome. Unlike the previous approach there are no global hotkeys
> involved.
> 
> Note this is a re-upload of
> https://codereview.chromium.org/66293004/
> 
> BUG=271719
> TEST=see bug
> 
> Review URL: https://codereview.chromium.org/68213004

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/70093003

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234953 0039d316-1c4b-4281-b951-d872f2087c98
Merge 233322 "[NaCl SDK] Set PEPPER_DIR properly when building n..."

> [NaCl SDK] Set PEPPER_DIR properly when building naclports.
> 
> This should be "pepper_NN", but was coming through as a path.
> 
> BUG=none
> R=sbc@chromium.org
> 
> Review URL: https://codereview.chromium.org/62753002

TBR=binji@chromium.org

Review URL: https://codereview.chromium.org/68113021

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234955 0039d316-1c4b-4281-b951-d872f2087c98
Incrementing VERSION to 32.0.1700.16

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234995 0039d316-1c4b-4281-b951-d872f2087c98
Merge 232931 "chrome.windows.create should return new window id ..."

> chrome.windows.create should return new window id in Guest mode
> 
> Some context: Chrome OS Guest mode is incognito mode and user extensions are
> disabled but we have couple component extensions that work in Guest mode.
> QuickOffice is one of them. It uses incognito split mode and runs in incognito
> profile. CanCrossIncognito returns false if extension runs in not split mode.
> Therefore include_incognito is false. But in general there is no problem
> if chrome.windows.create return incognito window if extension itself already
> works in incognito mode.
> 
> BUG=313789
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/49463006

TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/71723005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@234999 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234008 "This CL fixes the computation for HeaderPainter::s..."

> This CL fixes the computation for HeaderPainter::set_header_height() for browser popup windows. In particular, the top few pixels of the toolbar are semitransparent so the header must be painted underneath part of the toolbar.
> 
> BUG=316461
> TEST=Manual, see bug
> 
> Review URL: https://codereview.chromium.org/66003002

TBR=pkotwicz@chromium.org

Review URL: https://codereview.chromium.org/63173018

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235000 0039d316-1c4b-4281-b951-d872f2087c98
Merge 235085 "Always erase CBF_SMBITMAP from the clipboard objec..."

> Always erase CBF_SMBITMAP from the clipboard object map for async writes
> 
> This can never be a pointer to a valid object, since this CBF_SMBITMAP
> is only used for synchronous writes to the clipboard. This accidentally
> regressed in http://crrev.com/123088.
> 
> BUG=319125
> R=jorgelo@chromium.org
> TBR=creis@chromium.org
> 
> Review URL: https://codereview.chromium.org/72483002

TBR=dcheng@chromium.org

Review URL: https://codereview.chromium.org/71233005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235089 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234529 "Get Help M32 maniefst.json"

> Get Help M32 maniefst.json
> 
> BUG=314060
> TEST=manual
> 
> Review URL: https://codereview.chromium.org/57373006

TBR=cylee@chromium.org

Review URL: https://codereview.chromium.org/60563005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235106 0039d316-1c4b-4281-b951-d872f2087c98
Merge 233505 "Tear down IndexedDB dispatcher before WebKit is to..."

> Tear down IndexedDB dispatcher before WebKit is torn down
> 
> Ensure callback objects held by the Indexed DB dispatcher are released
> before WebKit and V8 are torn down, since the callback objects hold V8
> handles.
> 
> This is the same patch as crrev.com/50333004 which landed as r232620
> but reverted as r232649 due to timeouts on XP - I just tweaked the
> test constants slightly.
> 
> BUG=308988
> TBR=marja@chromium.org,jamesr@chromium.org,dgrogan@chromium.org
> 
> Review URL: https://codereview.chromium.org/58113002

TBR=jsbell@chromium.org

Review URL: https://codereview.chromium.org/68093005

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235167 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234098 "The back button on enrollment screen is needed to ..."

> The back button on enrollment screen is needed to ensure that users don't end up being stuck there in case of connectivity errors.
> 
> BUG=314717
> TEST=ProvisionedEnrollmentScreenTest.TestBackButton, WizardControllerKioskFlowTest.ControlFlowEnrollmentBack
> 
> Review URL: https://codereview.chromium.org/67073003

TBR=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/72883002

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235175 0039d316-1c4b-4281-b951-d872f2087c98
Merge 234444 "Don't set "print selection" to false."

> Don't set "print selection" to false.
> Before r231501 "print selection" was setup after InitPrintSettings. So reseting
> to false was OK. Now option is already there so we need to keep it.
> 
> BUG=317851
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/69033004

TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/73053003

git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@235228 0039d316-1c4b-4281-b951-d872f2087c98