add test for url generation