added module hr_worked_days_from_timesheet

Sandy,

je crois que tu ne regarde pas la bonne branche.

Les commentaires et les docstring sont déjà là.

Le commit qui ajoute les commentaires:
https://github.com/savoirfairelinux/hr/commit/147a076b38770327d2b36ba5f91576c8a9a98d7d

Ma branche:
https://github.com/savoirfairelinux/hr/tree/7.0-ddufresne-worked_days_from-timesheet

Mon pull request:
https://github.com/OCA/hr/pull/26

David

----- Mail original -----
De: "Sandy" <notifications@github.com>
À: "OCA/hr" <hr@noreply.github.com>
Cc: "David Dufresne" <david.dufresne@savoirfairelinux.com>
Envoyé: Vendredi 24 Octobre 2014 10:50:29
Objet: Re: [hr] added module hr_worked_days_from_timesheet (#26)



In hr_worked_days_from_timesheet/hr_payslip.py: > +        )
> +        date_format = lang_pool.read(
> +            cr, uid,
> +            lang_id,
> +            ['date_format'],
> +            context=context
> +        )[0]['date_format']
> +
> +        # delete old imported worked_days
> +        old_worked_days_ids = [
> +            wd.id for wd in payslip.worked_days_line_ids
> +            if wd.imported_from_timesheet
> +        ]
> +        self.pool.get(
> +            'hr.payslip.worked_days'
> +        ).unlink(cr, uid, old_worked_days_ids, context) 

Put that in the docstring or as a comment. You can't expect someone maintaining this piece of code to dig in the git history. 

— 
Reply to this email directly or view it on GitHub .