update test according to review