Remove clang warning suppressions, and fix fallout

Summary: We were suppressing various clang warnings. Mostly harmless
fixes. I think the pdo one was a real buffer overrun waiting to happen.

Reviewed By: @edwinsmith, @bertmaher

Differential Revision: D1566241