updated to ls convention