But all SoundSources use toUtf8 on non-Windows. If we change it to
toLocal8Bit then we should change all SoundSources.
On Jan 1, 2014 3:00 PM, "Daniel Schürmann" <notifications@github.com> wrote:

> In src/engine/sidechain/enginerecord.cpp:
>
> > @@ -274,7 +274,13 @@ bool EngineRecord::openFile() {
> >              m_sfInfo.format = SF_FORMAT_AIFF | SF_FORMAT_PCM_16;
> >
> >          // Creates a new WAVE or AIFF file and writes header information.
> > -        m_pSndfile = sf_open(m_fileName.toLocal8Bit(), SFM_WRITE, &m_sfInfo);
> > +#ifdef __WINDOWS__
> > +        LPCWSTR lpcwFilename = (LPCWSTR)m_fileName.utf16(); //Pointer valid until string changed
> > +        m_pSndfile = sf_wchar_open( lpcwFilename, SFM_WRITE, &m_sfInfo);
> > +#else
> > +        QByteArray qbaFilename = m_fileName.toUtf8();
>
> Yes, your objections where correct. "toLocal8Bit" is the right term here,
> because it is actually utf8 on Linux. Qt uses the codecForLocale here,
> which is set by locale command.
> On my system:
> $ locale
> LANG=de_DE.UTF-8
> LANGUAGE=de_DE
> LC_CTYPE="de_DE.UTF-8"
> LC_NUMERIC="de_DE.UTF-8"
> LC_TIME="de_DE.UTF-8"
> LC_COLLATE="de_DE.UTF-8"
> LC_MONETARY="de_DE.UTF-8"
> LC_MESSAGES="de_DE.UTF-8"
> LC_PAPER="de_DE.UTF-8"
> LC_NAME="de_DE.UTF-8"
> LC_ADDRESS="de_DE.UTF-8"
> LC_TELEPHONE="de_DE.UTF-8"
> LC_MEASUREMENT="de_DE.UTF-8"
> LC_IDENTIFICATION="de_DE.UTF-8"
> LC_ALL=
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mixxxdj/mixxx/pull/136/files#r8606734>
> .
>