Can we accept this pull request?  Let me know if you have other comments.

Thanks,

Shaoshan


From: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Date: Monday, February 24, 2014 10:15 AM
To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Subject: Re: [naarad] add Android RUM support to Naarad (#124)

Thanks, updated the code and the pull request.

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, February 24, 2014 8:45 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Subject: Re: [naarad] add Android RUM support to Naarad (#124)


In src/naarad/metrics/android_rum_metric.py:

> +      time_stamp = 0
> +      launch_time = 0
> +    else:
> +      time_stamp = start_time
> +      launch_time = end_time - start_time
> +    return (time_stamp, launch_time, nus_update_time)
> +
> +
> +  # parse Android RUM logs
> +  def parse(self):
> +    # check if outdir exists, if not, create it
> +    if not os.path.isdir(self.outdir):
> +      os.makedirs(self.outdir)
> +    if not os.path.isdir(self.resource_directory):
> +      os.makedirs(self.resource_directory)
> +


Use newlines sparingly within a method. See http://legacy.python.org/dev/peps/pep-0008/#blank-lines for more details.

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/124/files#r9998562>.