If I own it I expect dry clean code ;-)

-- 

Travis Fields

travis@puppetlabs.com 

Forge Module Engineer


Join us at PuppetConf 2014, September 22-24 in San Francisco

Register by May 30th to take advantage of the Early Adopter discount —save $349!

On Wed, Jun 4, 2014 at 11:32 AM, Ashley Penney <notifications@github.com>
wrote:

>>  
>> +  $config       = pick($os_config,        $default_config)
> I have to admit I don't really understand the point of this PR, it feels like a ton of churn for little gain.   Now we have this split between the default and os, and fallbacks via pick(), but I still don't really understand what we gain.  Maybe I'm just not getting it, but so far this feels like a bunch of change that doesn't gain us anything in features and makes this module different to all the other modules.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/puppetlabs-ntp/pull/161/files#r13402575