make popups more predictable

Related to https://github.com/ArcBees/GWTP/issues/554
My mistake, I'll add it back.


On Mon, Aug 25, 2014 at 4:12 PM, Christopher Viel <notifications@github.com>
wrote:

> In
> gwtp-core/gwtp-mvp-client/src/main/java/com/gwtplatform/mvp/client/HasPopupSlot.java:
>
> >       * @param child The popup child, a {@link PresenterWidget}.
> >       * @see #addToPopupSlot(PresenterWidget)
> >       */
> >      void addToPopupSlot(final PresenterWidget<? extends PopupView> child);
> >
> >      /**
> > -     * This method sets some popup content within the {@link Presenter}. The view
> > -     * associated with the {@code content}'s presenter must inherit from
> > -     * {@link PopupView}. The popup will be visible and the corresponding
> > -     * presenter will receive the lifecycle events as needed.
> > -     * <p/>
> > -     * Contrary to the {@link View#setInSlot(Object, com.google.gwt.user.client.ui.IsWidget)}
> > -     * method, no {@link com.gwtplatform.mvp.client.proxy.ResetPresentersEvent}
> > -     * is fired, so {@link PresenterWidget#onReset()} is not invoked.
> > -     *
> > -     * @param child  The popup child, a {@link PresenterWidget}.
> > -     * @param center Pass {@code true} to center the popup, otherwise its position
> > -     *               will not be adjusted.
> > -     * @see #addToPopupSlot(PresenterWidget)
> > -     */
> > -    void addToPopupSlot(final PresenterWidget<? extends PopupView> child, boolean center);
>
> Coming from an interface? This is more likely public in the
> implementation...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ArcBees/GWTP/pull/555/files#r16657034>.
>