Change private addPrincipals to collectPrincipals; returns a set rather than adding to one taken as a parameter.
Use EVERYONE constant in test
Use diamond operator
Declare variables on the lines they are assigned
Fix param name in docs
Set user principal to EVERYONE if credentials don't have the fedoraUser role
Compare principal's name with result from getUserName
Fix spacing and expand implementor note for PrincipalProvider
Rename PEP to FAD. For AbstractRolesPEP and BasicRolesPEP, spell out FAD as AuthorizationDelegate, so we have AbstractRolesAuthorizationDelegate and BasicRolesAuthorizationDelegate.