It overflows when you add today's date in seconds. That's what OpenSSL does
internally, at least prior to 1.0.0.


On Thu, May 8, 2014 at 1:58 PM, Kristian Amlie <notifications@github.com>wrote:

> In libcfnet/tls_generic.c:
>
> > @@ -191,7 +191,7 @@ X509 *TLSGenerateCertFromPrivKey(RSA *privkey)
> >      }
> >
> >      ASN1_TIME *t1 = X509_gmtime_adj(X509_get_notBefore(x509), 0);
> > -    ASN1_TIME *t2 = X509_gmtime_adj(X509_get_notAfter(x509), 60*60*24*365*50);
> > +    ASN1_TIME *t2 = X509_gmtime_adj(X509_get_notAfter(x509), 60*60*24*365*10);
>
> Are you sure? The old expression doesn't overflow the 32-bit int, AFAICS.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cfengine/core/pull/1685/files#r12424915>
> .
>