remove unused parseFromDateUTC method

Change-Id: I9310b29be1831f5132dec0e1ea36ee2277289e58
Reviewed-on: https://gerrit.instructure.com/31978
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
remove event type parameter on $.parseFromISO

it was never (legitimately) used. the few calls that provided it didn't
need to, as it only effected the format in datetime_string, which was
not accessed on the results of any of these calls

Change-Id: Ibb02b9abb1154b301ac338bb1c747aae7da1b99e
Reviewed-on: https://gerrit.instructure.com/31979
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
simplify some date/time formatting in parseFromISO

Change-Id: I585af20e47a0884f5eab7fdc37f15752eeab7805
Reviewed-on: https://gerrit.instructure.com/31980
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
remove $.dateToISO8601UTC and $.dateToISO8601

unnecessary; use date.toISOString(). the latter was even unused.

Change-Id: Ia8e27f40e35e0546f57b3dd6d762fc3baa016a5d
Reviewed-on: https://gerrit.instructure.com/31981
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
spec: {{friendlyDatetime}} handlebar helper

Change-Id: Ic5b697c48b6f5f133d240745b7cc82598df6a6cb
Reviewed-on: https://gerrit.instructure.com/31982
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
convert $.dateString and friends to use tz()

that means those methods now need to be passed unfudged values, so go
clean up the call sites, too. streamlined some of the stuff around the
call sites while at it.

Change-Id: I0c109b7c047546802acb019d473754667cfbcdec
Reviewed-on: https://gerrit.instructure.com/31983
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
remove crazy one-off time formatting

just use tz.format(timestamp, ...) formatting (and $.dateString and
friends). fudgeDateForProfileTimezone can take any argument to
tz.parse(), including timestamps, so we don't need to instantiate that
first. the show_time property was never used.

Change-Id: I53acbcfdeb84cc517151b1af8a4f944a5b9c7489
Reviewed-on: https://gerrit.instructure.com/32108
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
clean up the handlebars helpers to use tz()

or $.dateString and friends, as appropriate

Change-Id: I7028626f4e17414c7dc9ef7eb27e50cae21aa3bc
Reviewed-on: https://gerrit.instructure.com/32109
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
goodbye, $.parseFromISO

the vast majority of calls were only to access:

 * the parsed-then-fudged value; this can be accomplished with just
   fudgeDateForProfileTimezone (given an ISO string it will parse it,
   format it relative to the profile timezone (without tz info), then parse
   it relative to the browser timezone. unfudging this result will give
   you back a time accurately representing the original string)

 * one or more formattings of the parsed value; use the appropriate
   formatter (if multiple are used, parse with tz.parse() first for
   efficiency)

one notable exception was in the gradebook (both regular and
screenreader). it was using parseFromISO to parse the ISO string
received from the server, but then only sometimes treating that as a
object while other times assuming (incorrectly) that it had a Date
object or timestamp. we make it always be a Date object, and fix the
places that assumed it needed to be a parseFromISO result object.

Change-Id: I86c077c046e74760a538849ce58f2952ada1fb99
Reviewed-on: https://gerrit.instructure.com/32110
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Anthus Williams <awilliams@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
Merge branch 'dev/timezunami' into master

test-plan:
  full regression of dates and times

Change-Id: Ic89b0d06f6675a194e5305f70dfa70df82b3f1b9
Merge "Merge branch 'dev/timezunami' into master"