finsihing the framwork