trade methods tests passing