Ah yes I meant to remove these. My mistake. I'll pull them out in the next
revision.

~Scott
On Mar 15, 2014 5:43 PM, "Roberto Tyley" <notifications@github.com> wrote:

> In agit/res/values/strings.xml:
>
> > +    <string name="setting_sync_frequency_key">setting_sync_frequency</string>
> > +
> > +    <string name="setting_sync_frequency_daily">0</string>
> > +    <string name="setting_sync_frequency_daily_title">Sync daily at</string>
> > +    <string name="setting_sync_frequency_daily_hour_key">setting_sync_frequency_daily_hour</string>
> > +    <string name="setting_sync_frequency_daily_min_key">setting_sync_frequency_daily_min</string>
> > +
> > +    <string-array name="setting_sync_choices">
> > +        <item>Manually</item>
> > +        <item>Schedule daily at&#8230;</item>
> > +        <item>Every 15 minutes</item>
> > +        <item>Every hour</item>
> > +        <item>Every 3 hours</item>
> > +        <item>Every 6 hours</item>
> > +        <item>Every 12 hours</item>
> > +        <!-- <item>Every week on&#8230;</item> -->
>
> Please remove these unnecessary items (the commented out options) - from a
> user experience perspective, I don't think they make any sense (grab Git
> repos every Monday? what's wrong with daily or weekly?), and you should
> always prefer to remove unnecessary source code.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/rtyley/agit/pull/103/files#r10637045>
> .
>