(#21817) Ignore duplicate certs

Previously, SSL connections initiated by the puppet agent on windows, e.g
puppet module install, would cause the agent to terminate if the 'Root' store
on Windows contained duplicate certificates.

This commit ensures that we only add unique certificates to the X509 store.
Also, if we fail to add a certificate to the store, we issue a warning and
continue.
init: Check if running if not configured to start.

The reasoning for this is explained in:
https://projects.puppetlabs.com/issues/23033

Currently the init-script does not actually check if we're running and
return accordingly when status is called if the puppet master is not
configured to start.

This causes it to always return 0, meaning we're actually running
regardless of if that is the case.
(maint) Remove stale files from ext/rack

The ext/rack directory had an outdated README file and an ancient manifest.pp
file, and the useful files (config.ru and the example vhost) were buried in a
subdirectory.

This commit removes the old files, moves the good files up a level, and adds a
comment to the vhost pointing to the maintained passenger documentation.
(maint) Update debian packaging to reference new rack support location

As updated in commit 4c9b63f, the sample files for rack passenger deployment
have been moved up a directory. The puppetmaster-passenger package for debian
uses those files, so this commit updates the debian/rules file with their new
location. It also updates the README_DEVELOPER.md, which references the same
files.
Maint: Reformat docs for Augeas type's "changes" attribute

I'm trying to get DL elements out of the docs, and this fragment works better as
a more compact list anyway.
Maint: Reformat indirection reference to use H4s instead of DLs for termini

A long time ago, I shortsightedly decided to use the definition list Markdown
extension in some of our docs. Time and the renderer ecosystem haven't been kind
to that syntax, so we need to get away from them if we want to be able to switch
relatively freely between various MD processors.

This commit removes them from the last embedded documentation that we still use.
The old-style type reference still uses them, but since we've stopped relying on
it and moved to our own implementation, that should be fine.
(#23074) Add reinventory command to puppet cert

This adds a reinventory command to the puppet cert application.

Further work on this is to refactor the use of the #apply method
found in Puppet::SSL::CertificateAuthority as it delegates to
a subclass called Interface to do the work. This is all an application
concern and it is confusing with the back and forth between the classes
"the cert application", the CA and its Interface.
(#23074) Add text to warn that master should be inactive for reinventory.
(#23074) Cleanup logic

This makes a couple of the methods in the CertificateAuthority and
related Interface classes easier to read / understand.
(#23074) Remove header in inventory.txt when regenerating

The regenerate inventory wrote a header that was not there in the
original file.
(#23074) Make cert inventory not rebuild inventory.txt when adding

There is a race condition that requires protection if the inventory
performs rebuild of a missing inventory.txt file when adding a cert.
Without the protection the inventory may end up with double entries or
missing entries, and with the protection the processing of cert requests
become serialized over all processors creating a performance problem.

This change simply appends to the inventory.txt - if the file does not
exists, it is atomically created.

A users that wants to recreate the inventory should do so with the
command `puppet cert reinventory` which may be executed on an
inactive system.
(#23074) Refactor cert application's use of cert authority's interface

The code was difficult to understand as the cert application called
the apply function on the CertAuthority, which in turned created an
instance of the Interface class, which in turn called back into the
ca. As this construct was only used by the cert application, the ca's
apply method was moved to the cert application.

It is now more clear that the application interacts with the ca via
an instance of its Interface class.
(#23074) Remove overly stubbed tests

There were several tests attempting to test the cert application,
the CertificateAuthority and its interface, as well as the inventory
handling by use of excessive stubbing that prevents any real code from
being tested.

The failing overly mocked tests have been removed. Their value was
questionable to begin with.
(#23081) Ensure that errors from insync? create proper events
(Maint) Reorder and reduce scope of harness

This makes non-public methods explicitly private. It also reorders the
methods to read in a manner where the top is the public and highest
level, and it becomes more low level as we move down the file.
(#23801) Add unit tests for insync? raising StandardError or Exception
(maint) Remove large spec test block whose benefits were unclear.

This changes removes a large block of unit tests, comprising
1296 individual tests built up via 8 nested 'each' loops. Why
remove so many tests?

First, in the course of refactoring for #23081 we triggered
test failures in this block only when we also triggered a test
failure elsewhere, and conversely, it didn't trigger failures
where other individual tests did register a useful failure.

Second, several people have stared at this unit test block
and not been able to figure out what it is uniquely testing.

So in short the value of this test block is not clear, so we're
removing it.  Of course, if we hit future gaps in unit test coverage,
we'll add tests back in to cover gaps.
(maint) Remove an unimplemented test and fix up some comments.
(#23085) Ensure old puppet agents get properly stopped when upgrading from 2.6 or early to 2.7 or later
Merge pull request #2036 from kylog/issue/23081/report-property-event-for-insync-exceptions

Issue/23081/report property event for insync exceptions