Fix check_ssh_injection in cinder/utils

check_ssh_injection is used to prevent commands being modified using
specially constructed strings containing special characters.

The function includes a loop over the special characters to compare
them against each arg. If the special character is the same as the arg
it gets ignored.

This commit modifies this part of the function so that args that are
exactly equal to one of the special characters will cause an exception
to be raised.

Change-Id: I3a61e995ea41fc0324b5cb60e3c96e3d9dc56637
Closes-Bug: #1398002
Raise exception if invalid IP is specified

This patch ensures that all values specified for the configuration
option netapp_controller_ips are valid, rather than logging and
continuing with only the valid addresses.

Closes-Bug: 1396718

Change-Id: I180dc74e4535bfde19f1741cff975f5ec675dd21
Don't use _execute directly in brick/iscsi

The brick/iscsi module has a run helper that
should be used for executing commands.  There
are a number of inconsistencies where _execute
is called directly.

This patch moves everythign to use the run method
to keep things consistent and also to fix up some
potential issues with variables becoming corrupt
under heavy load.

Change-Id: Idfc183f2ed1ad73b64fc893efcc07972c95926c6
Merge "Fix check_ssh_injection in cinder/utils"
Merge "Raise exception if invalid IP is specified"
Merge "Don't use _execute directly in brick/iscsi"