Remove self comparisons in test/extern/ferguson/c_ptrs.chpl

c_ptrs.chpl had comparisons that looked like:

assert(my_ptr == my_ptr);

These now check that my_ptr != c_nil. I added a couple of overloads in
SysBasic to allow comparison between c_ptr and c_void_ptr to let us do
this.
Snapshot -- got 3D working, but broke 1D
This version works for 1D and 3D again
Fix overlapping memory in memcpy() reported by valgrind.

This was a slam-dunk.  I replaced every direct call to memcpy() in our runtime code with a
call to chpl_memcpy(), then defined the latter as an always-inlined function that calls
through to the real memcpy().

The symptoms of the valgrind error are that the source and destination address are the
same (as I suspected).  So I added an assert for that error case and tracked down the
caller.  In chpl_gen_comm_get, there is the possibility that the source and destination
address are the same, if the data being fetched resides on the same locale.  That is where
I fixed the problem.

It would be possible to also fix the problem in the calling module code, but there we
would have to add a primitive to perform pointer comparison.  It is far easier to do this
in the runtime code.

I concluded that it would be helpful to leave the chpl_memcpy wrapper in place.  If NDEBUG
is true, then the assert will expand to nothing, and the whole routine will inline to a
direct call to memcpy.  So the runtime cost of this extra code should be nil (with
optimizations enabled).
Remove the refvar keyword

Remove refvar from the language, replacing it with the ref keyword.

Doing this requires removing the deprecated `ref(var1,var2)` task intent
syntax. Using that form will now be a syntax error rather than a
warning.

While there I cleaned up buildVarDelcs to take in a set of Flags to
apply to the variable, rather than passing them through three different
variables that would often just be set to FLAG_UNKNOWN and ignored.
Update tests to use  instead of
Cleanup.  Now passes testing.
Can't see why 1D and 3D should be treated differently here.
Add case to lock in 3x3x3 error that's been around forever
Removing debug printing from today's session
Removing Sung's lulesh studies test

With the bug fixes of the earlier commits here, I verified that the
release version subsumes Sung's version and outperforms it when
compiled in the similar configuration (probably due to using atomics
rather than syncs).  Given that this test is now redundant and that
we're getting timeouts on it in many configurations, I think it's time
to remove it.
Truncate norms and Fvals and update .good files.
Add .execenv files to set QT_NUM_SHEPHERDS=2 and update .lm-numa.good files

The number of communications depends on the number of shepherds when using the
numa locale model, so force the number of qthreads shepherds to 2.  Update
the .lm-numa.good files to match the comm counts for two shepherds.
Updated according to comments from gbt:

Moved the src==dest test out of chpl_gen_comm_get() and into chpl_memcpy().

Adjusted indentation in chpl-cache.c, due to wider function name (chpl_memcpy vs. memcpy).

diff --git a/runtime/include/chpl-comm-compiler-macros.h b/runtime/include/chpl-comm-compiler-macros.h
Merge branch 'quietMadchap' of https://github.com/chapel-lang/chapel into quietMadchap
Merge pull request #748 from Kyle-B/kb-refvar-to-ref

Remove the refvar keyword

Remove `refvar` from the language, replacing it with the `ref` keyword.

Doing this requires removing the deprecated `ref(var1,var2)` task intent
syntax. Using that form will now be a syntax error rather than a
warning.

While there I cleaned up buildVarDelcs to take in a set of Flags to
apply to the variable, rather than passing them through three different
variables that would often just be set to FLAG_UNKNOWN and ignored.
Remove redundant truncation of fval and update test_diff.good.
Merge pull request #743 from Kyle-B/kb-remove-self-comparison

Remove self comparisons in test/extern/ferguson/c_ptrs.chpl

c_ptrs.chpl had comparisons that looked like:

assert(my_ptr == my_ptr);

These now check that my_ptr != c_nil. I added a couple of overloads in
SysBasic to allow comparison between c_ptr and c_void_ptr to let us do
this.
Skip testing multilocale lammps/lsms files under comm=none.
Merge branch 'fixMemcpyOverlap' of github.com:hildeth/chapel into fixMemcpyOverlap

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.