Looks like another bad test. Looks like the test already confirms the content that's all that's important.
________________________________
From: David Kowis [notifications@github.com]
Sent: Tuesday, February 25, 2014 3:34 PM
To: rackerlabs/repose
Cc: Adrian George
Subject: Re: [repose] Added Dist Datastore tests and a fix for PATCH 500 (#880)


In repose-aggregator/functional-tests/spock-functional-test/src/test/groovy/features/services/datastore/DistDatastoreServicePatchTest.groovy:

> +        def largeBodyContent = RandomStringUtils.random(2006139, ('A'..'Z').join().toCharArray())
> +        def largeBody = ObjectSerializer.instance().writeObject(new com.rackspace.papi.components.datastore.StringValue.Patch(largeBodyContent))
> +
> +        when:
> +        MessageChain mc = deproxy.makeRequest([method: 'PATCH', url: DD_URI + KEY, headers: DD_HEADERS, requestBody: largeBody])
> +
> +        then:
> +        mc.receivedResponse.code == '200'
> +
> +        when: "I attempt to get the value from cache"
> +        mc = deproxy.makeRequest([method: 'GET', url:DD_URI + KEY, headers:DD_HEADERS])
> +
> +        then:
> +        mc.receivedResponse.code == '200'
> +        ObjectSerializer.instance().readObject(mc.receivedResponse.body as byte[]).value == largeBodyContent
> +        mc.receivedResponse.body.length == 2097152


@dimtruck<https://github.com/dimtruck> This seems to fail every time this test is executed. What is this verifying? The size is never exactly 2097152.

—
Reply to this email directly or view it on GitHub<https://github.com/rackerlabs/repose/pull/880/files#r10056986>.