sounds good to me.


On Wed, Feb 26, 2014 at 11:26 AM, Xiangrui Meng <notifications@github.com>wrote:

> In src/main/scala/breeze/linalg/distance.scala:
>
> > @@ -0,0 +1,27 @@
> > +package breeze.linalg
> > +
> > +import breeze.generic.UFunc
> > +import breeze.generic.UFunc.UImpl2
> > +
> > +/**
> > + * TODO
> > + *
> > + * @author dlwh
> > + **/
> > +object distance extends UFunc {
>
> Is it okay to provide squaredDistance instead of distance? sum_i dist(a_i,
> b_i)^2 is more common than sum_i dist(a_i, b_i). Note that Mahout's
> implementation would use an approximation if two vectors are close to
> orthogonal, which is faster for randomly generated vectors. It might run
> faster for high dimensional data, but it becomes much slower if the two
> vectors are not close to orth.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mengxr/breeze/pull/1/files#r10094688>
> .
>