I'd use instance variables here instead of attr_accessor unless you want people to modify these values from outside this class.  I don't see a need for that right now.