builder: ONBUILD triggers were not accurately being executed in JSON cases

closes #8520

This re-invokes the parser for onbuild instructions. The method signatures for the dispatchers needed to change, so sorry about the extra noise.

/cc @crosbymichael @tiborvass @tianon 
Yes, all of them otherwise use the shell syntax. There are a few tests that are very similar, but use shell syntax too..

-Erik

On Oct 13, 2014, at 2:56 PM, Michael Crosby <notifications@github.com> wrote:

> In integration-cli/docker_cli_build_test.go:
> 
> > @@ -14,6 +15,78 @@ import (
> >  	"github.com/docker/docker/pkg/archive"
> >  )
> >  
> > +func TestBuildOnBuildCmdEntrypointJSON(t *testing.T) {
> > +	name1 := "onbuildcmd"
> > +	name2 := "onbuildgenerated"
> > +
> > +	defer deleteAllContainers()
> > +	defer deleteImages(name2)
> > +	defer deleteImages(name1)
> > +
> > +	_, err := buildImage(name1, `
> > +FROM busybox
> > +ONBUILD CMD ["hello world"]
> Are there any ONBUILD tests without the json syntax?
> 
> —
> Reply to this email directly or view it on GitHub.
>