check for empty strings too