edit settings now complete