Formatting
Add check to VERIFY_VP to check that the string buffer is still \0 terminated, and that the length of the of the buffer matches the length of the VALUE_PAIR.
Valgrind complains about sscanf in rlm_eap_mschapv2.c reading past the end of response->vp_strvalue. Use VERIFY_VP to check that this can't be happening.
Reorder operations in mschap_add_reply to try and unconfuse valgrind
Don't leak memory when pairmake is called with a regular expression comparison
Another regex memory leak...
Formatting and cases of vp_strvalue being used for octet type attributes
Always \0 terminate string type attributes in mschap_add_reply()
Use "ignoring" instead of bureaucratic sounding phrase
Check length of octets type attributes too
Output contents of authenticator in radsniff
Always print authenticator even if there are no vps
More tracing on dup / conflicting packet
A dup isn't a dup if the old request is done
turn VERIFY_VP into a function, the macro was getting very long
Comments
Formatting
Use realloc to correct the length of char buffers in pairparsevalue
sp
It's OK for the buffer to be too big.

Also print out the name of the offending attribute