Classic: Fix the right analog stick on the Classic Controller

The right analog stick has half the precision of the left stick on the
wire. This was a simple copy/paste error when converting everything from
the templated code elsewhere.
I think a comment explaining what is happening or giving reference material
should be fine if a constant can't explain well enough.

If linking to reference material, I'd put a gist of what is happening and
then the link so in case the site goes down, if ever, people aren't totally
left in the dark by a dead link.

In Source/Core/Core/HW/WiimoteEmu/Attachment/Classic.cpp:

> @@ -102,8 +102,8 @@ void Classic::GetState(u8* const data)
>  	u8 x_, y_;
>  	m_right_stick->GetState(&x, &y);
>
> -	x_ = (x * 0x1F) + 0x20;
> -	y_ = (y * 0x1F) + 0x20;
> +	x_ = (x * 0x0F) + 0x10;

Let's have @Lioncash <https://github.com/Lioncash> decide that coding style
related question since none of us will change position :p
… <#1474ad01df5cd097_>
On Fri, Jul 18, 2014 at 8:41 PM, Jasper St. Pierre <notifications@github.com
> wrote: In Source/Core/Core/HW/WiimoteEmu/Attachment/Classic.cpp: > @@
-102,8 +102,8 @@ void Classic::GetState(u8* const data) > u8 x_, y_; >
m_right_stick->GetState(&x, &y); > > - x_ = (x * 0x1F) + 0x20; > - y_ = (y
* 0x1F) + 0x20; > + x_ = (x * 0x0F) + 0x10; Well, it's not the "C stick" on
classic controllers, it's just the "right analog stick". I don't really
think adding names for this will make the code clearer. I could point add a
comment saying with a link to
http://wiibrew.org/wiki/Wiimote/Extension_Controllers/Classic_Controller ,
and add that the range of the right analog stick is half of the left, for
no discernible reason. — Reply to this email directly or view it on GitHub <
https://github.com/dolphin-emu/dolphin/pull/648/files#r15127009>.
 -- Pierre "delroth" Bourdon <delroth@gmail.com> Software Engineer @
Zürich, Switzerland http://code.delroth.net/

—
Reply to this email directly or view it on GitHub
<https://github.com/dolphin-emu/dolphin/pull/648/files#r15127423>.