revising data generator