On 13 March 2014 12:55, Juan Martin Runge <notifications@github.com> wrote:
>
> In drivers/status/pubsub.js:
>
> >  };
> >
> >  CaspaDriver.prototype.setupMessages = function(callback) {
> >      // I think we should assume at init there's no sticky errors?
> > -    this.db.collection('mostomessages').remove(callback);
> > +    // So we either mark them as fixed or just clean up the db?
> > +    MostoMessagesCollection.fetch({ success: function() {
>
> Reopening would mean that it was marked as resolved before, doesnt it? In that case, it would be a new error. If it was not resolved, and persists, we should do nothing. If it was resolved, mark it as resolved. Perhaps we should check unresolved errors on startup and see if they went fixed or not...


I got your comment mixed up with another code block.
The original code just dropped everything, if the error persists it
would be triggered again.
Now we don't do that but on a second thought it is probably better to
have the old behaviour again.