Use assertIn where appropriate

Change-Id: I27038279067183352e5a54766fb74515057d581a
Mention --fixed-ip subnet_id=<..> in help message

Improved help message for port-create --fixed-ip subnet_id=<..> case:
 * ensure it's mentioned when no arguments are passed;
 * fixed wording of --help message to make it clear subnet_id may be
   passed without ip_address.

Change-Id: Ie48099e0445f80dbff78766e42bc548f925cd208
Closes-Bug: #1267465
Combine debug and verbose commandline options

Most of the openstack clients (for example nova) when --debug is specified it
shows the api calls the client is making. However, when debug is passed into
the neutronclient it shows exceptions that have occurred inside the
neutronclient. This patch combines verbose and debug to do the samething.

Change-Id: I6f2e0b17ffbe8fbfa77e26222dae32f5ab1e8866
Closes-bug: #1260489
Adding weight column to Neutron lb member list CLI

Adding 'weight' column to lbaas member-list command in order to quickly
identify member properties. Protocol port was already been shown.
This avoids having to enter each member details to see the weights
settings.

Change-Id: Id3c8cd8b3304535e2d82777018121007ed3bb129
Closes-Bug: #1267575
update coveragerc file

fix missing change from quantumclient to neutronclient in .coveragerc
exclude tests from code coverage calculation

Change-Id: Ie286faaaaad9e9bc72c89422ac628178a30ccc8e
Rename Nicira NVP to VMware NSX in neutronclient

Use new naming scheme to reflect rebranding.

Partial-implements blueprint nicira-plugin-renaming

Change-Id: I694fbda1c228e92a0b910358523787fa742d9ab2
Add shared parameter for metering labels

With this patch metering labels can
be set as shared so that the rules
associated with this label will be
applied to all routers for all tenants.

Partially implements
blueprint l3-metering-mgnt-ext

Change-Id: I23f9fb9cf17c7a20069616bb1c4ae19a5dc55d68
Fixed a minor typo in a docstring

Change-Id: I4d822513cc65662a988c7ad10b01ff04fa7d6890
Fixed get_auth_info() for pre-authenticated clients

When a client is instantiated with pre-defined authorization token,
no authentication is done, so no auth_[tenant|user]_id keys are set
for HTTPClient. As a result, Client.get_auth_info() fails with KeyError.

Fixed the issue by setting those keys on HTTPClient initialization.

Change-Id: Ifc9d6b128286b635346a7bc026fcc55dbd002050
Closes-Bug: 1277120
Support building wheels (PEP-427)

Universal is used to identify pure-Python module(by bdist_wheel). For
these, it is sufficient to build a wheel with _any_ Python ABI version
and publish that to PyPI (by whatever means).

Change-Id: I3dd06b63d2fdcce8961f87fe1d71be052cb0fdf0
Merge "Rename Nicira NVP to VMware NSX in neutronclient"
Remove vi modelines

We don't need to have the vi modelines in each source file,
it can be set in a user's vimrc if required.

Change-Id: Ic30e91df1b0e25beda9b8d8c19be58573cdae4f6
Closes-Bug: #1229324
Merge "Fixed get_auth_info() for pre-authenticated clients"
Fix net-gateway-create help message

"neutron help net-gateway-create" said:

  --device DEVICE Device info for this gateway device_id=<deviceidentifier>...

However, actually parameter name of DEVICE is "id". Not "device_id".

Change-Id: Ifa19f11f250101ddf4803c3c591bb19274fae869
Closes-Bug: #1262527
Extending quota support neutron LBaaS entities

Note: This change is a continuation of the abandoned
      change https://review.openstack.org/#/c/59192/
      Previous change was abandoned due to rebase problem.

Extending quota mechanism to support neutron
LBaaS entities. Adding quota for vips, pools, members
and health monitors.

This is one of four changes related to the BP.
This one is for python-neutronclient package.
Another one is for neutron project, another for tempest project
and another one for horizon/openstack-dashboard project.

See blueprint neutron-quota-extension for another two changes.

Change-Id: I2bfb974d513bd21b4dac6c90ddc6ede19797caf9
Implements: blueprint neutron-quota-extension
Modify quota-list descripton

'quota-list' is truly to descirbe quotas for tenants who have non-default
quota values.

Change-Id: I9b5cc92afda9ec7ace479f456c303a3ecc5672d0
Closes-bug: #1280519
Work around for httplib2 retries on timeout

httplib2 automatically retries a request on a timeout even if the request
is a POST. This can lead to orphaned objects being created that we
don't know about. This patch sets httplib2.RETRIES to 1 to avoid this.

Note: httplib2.RETRIES is only available in new versions of httplib2.
See: https://code.google.com/p/httplib2/issues/detail?id=124 for more
details.

Co-Authored-By: Ashwin Raveendran <ashw7n@gmail.com>
Co-Authored-By: Sudheendra Murthy <sudhi.vm@gmail.com

Change-Id: I5648b644bb9df1fd2ea219159794d9d122696af0
Closes-bug: #1267649
Don't reuse 'body' for response data

It makes diagnostics in debuggers much harder - we can just use a
different variable name instead.

Change-Id: I69367336cbb0f9f302ef8d484a5d504d2b3869bb
Merge "Mention --fixed-ip subnet_id=<..> in help message"
Merge "update coveragerc file"