sounds good, thanks


On Tue, May 27, 2014 at 10:19 AM, Greg Caporaso <notifications@github.com>wrote:

> In skbio/parse/sequences/fastq.py:
>
> > @@ -158,10 +157,11 @@ def parse_fastq(data, strict=False, phred_offset=33):
> >              # http://nar.oxfordjournals.org/content/38/6/1767/T1.expansion.html
> >              elif linetype == QUAL:
> >                  qual = phred_f(line)
> > -                if (qual < 0).any() or (qual > 62).any():
> > -                    raise FastqParseError("Failed qual conversion for seq "
> > -                                          "id: %s. This may be because you "
> > -                                          "passed an incorrect value for "
> > -                                          "phred_offset." % seqid)
> > +                if enforce_qual_range:
> > +                    if (qual < 0).any() or (qual > 62).any():
>
> Ok, @adamrp <https://github.com/adamrp>, your code so you choose to
> change or leave as-is. @wasade <https://github.com/wasade>, going to
> assign this PR to you for final review/merge when it's ready, ok?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/biocore/scikit-bio/pull/394/files#r13086493>
> .
>