lower to upper or upper to lower
add doc string