Cool, beware if you find that you are writing last_non_comment_activity ||
last_comment_at means that you really mean last_activity_at. Watch out for
it.



On Sun, Jan 26, 2014 at 9:47 PM, Aaron Thornton <notifications@github.com>wrote:

> In app/models/discussion.rb:
>
> > @@ -7,7 +7,7 @@ class Discussion < ActiveRecord::Base
> >    scope :archived, -> { where('archived_at is not null') }
> >    scope :published, -> { where(archived_at: nil) }
> >
> > -  scope :active_since, lambda {|some_time| where('created_at >= ? or last_comment_at >= ?', some_time, some_time)}
> > +  scope :active_since, lambda {|some_time| where('last_non_comment_activity_at >= ? or last_comment_at >= ?', some_time, some_time)}
>
> We could bundle them together for this scope, but they are still required
> individually for rendering the template.
> Loving this review Rob, by the way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/loomio/loomio/pull/1226/files#r9174942>
> .
>