Strip rh valid fix

SiStripRecHitsValid:  Fix a bug that was disabling filling of histos for no. of recHits by subdet.  Adjust the binning of the now-enabled histograms.
  For matched recHits, limit the simHits projected from the stereo sensor to those actually on the stereo sensor.
TrackerHitAssociator:  For matched recHits, suppress ghost hits by requiring a simTrack association.
No.  I copied from the method associateHitId in this same class, where 
it has been present all along.  This new instance in associateHit is 
outside any loops once this function has been called, so it adds one 
occurrence on top of one to three occurrences invoked by the upstream 
call to associateHitId.

There is no gross change in the execution time (3:28 vs 4:07 minutes for 
10 events, in batch with no control on processor speed), but I can run a 
more controlled test.

On 08/11/2014 03:26 PM, Giulio Eulisse wrote:
> In SimTracker/TrackerHitAssociation/src/TrackerHitAssociator.cc:
>
>> @@ -153,6 +153,12 @@ std::vector<PSimHit> TrackerHitAssociator::associateHit(const TrackingRecHit & t
>>      //  from the DigiSimLinks and returned in simhitCFPos.
>>      //  simhitCFPos[i] contains the full address of the ith simhit:
>>      //   <collection, index> = <<subdet, tofBin>, index>
>> +
>> +    //check if the recHit is a SiStripMatchedRecHit2D
>> +    bool isMatchedHit = false;
>> +    if(dynamic_cast<const SiStripMatchedRecHit2D *>(&thit))
>
> dynamic_casts can be expensive. Did you check there were no regressions
> performance wise?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cms-sw/cmssw/pull/4912/files#r16081615>.
>