I'm not sure I understand why parametrize would improve this but splitting 
them is fine.


On 7 February 2014 18:20:03 David Reid <notifications@github.com> wrote:

> > +        assert pkey.public_exponent == pkey.e
> > +
> > +        assert skey.key_size
> > +        assert skey.key_size == pkey.key_size
> > +        assert skey.key_size == pkey2.key_size
> > +
> > +        assert skey.p * skey.q == skey.modulus
> > +
> > +    def test_invalid_argument_types(self):
> > +        with pytest.raises(TypeError):
> > +            rsa.RSAPrivateKey(None, None, None, None, None)
> > +
> > +        with pytest.raises(TypeError):
> > +            rsa.RSAPublicKey(None, None)
> > +
> > +    def test_invalid_argument_values(self):
>
> Maybe this should be broken up into tests for RSAPrivateKey and tests for 
> RSAPublicKey? Then maybe you also use parametrize?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pyca/cryptography/pull/559/files#r9548870