edit attrs