yes it is right. once the 4th child is removed then the 5th child becomes
4th so effectively the 4th and 5th child are removed. if you think it is
wrong please test the code and then comment only then it would be
productive else it is just a waste of time.

I have tested the code you can also do so and let us know if there is some
bug in the big fix

Thanks,
Krtin


On Wed, Mar 12, 2014 at 12:06 AM, Dennis1993 <notifications@github.com>wrote:

> In js/makegrid.js:
>
> >                              if (typeof data.sql_query != 'undefined') {
> > -                                // display feedback
> > -                                $('#sqlqueryresults').prepend(data.sql_query);
> > +                                //extract query box
> > +                            	var $result_query = $($.parseHTML(data.sql_query));
> > +                            	var sqlOuter = $result_query.find('.sqlOuter').wrap('<p>').parent().html();
> > +                            	var tools = $result_query.find('.tools').wrap('<p>').parent().html();
> > +                                // If two query box exists update query in second else add a second box
> > +                                if($('#result_query').find('div.sqlOuter').length>1) {
> > +	                               $('#result_query').children(":nth-child(4)").remove();
> > +	                               $('#result_query').children(":nth-child(4)").remove();
>
> It is right? The line 1325 and 1326 are the same?
>
> I can't see diffent changes:
> $('#result_query').children(":nth-child(4)").remove();
> $('#result_query').children(":nth-child(4)").remove();
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/phpmyadmin/phpmyadmin/pull/1020/files#r10488789>
> .
>