hash construction preferences

I think it depends on the context. If you are making a hash with simple attributes for a test or something, where you don't care about the values themselves, then you can make it a one-liner. If it's long, and the assignments aren't simple, I'd space it out.